Update to use NamedTemporaryFile rather than mktemp #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tempfile.mktemp() has been deprecated (see https://docs.python.org/3/library/tempfile.html#tempfile.mktemp) due to security vulnerability, here I have taken the recommended course of action by replacing with tempfile. NamedTemporaryFile() to resolve the vulnerability. (Our sagemaker-python-sdk package uses multiprocess and was flagged for this vulnerability, please merge and release ASAP!)
I ran py3.10 tests successfully.
Checklist
Documentation and Tests
python tests/__main__.py, and pass.Release Management